Prevent declared field to have additional lookups #1019
Closed
+24
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1019 +/- ##
=======================================
Coverage 98.33% 98.33%
=======================================
Files 15 15
Lines 1198 1198
=======================================
Hits 1178 1178
Misses 20 20
Continue to review full report at Codecov.
|
|
@rpkilby Was wondering if this was still required? |
|
Hi @PaiAkshay998. You can close this. The issue isn't directly related to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've included an extra check for all fields other than the LookupChoiceFilter to check that if a field which is specified in Meta.fields also exists in declared fields, then make sure that the lookup expressions match; ie declaration of fields in both Meta.fields and the declare fields agree on the same lookup expressions for that field.
I'm not sure if this covers all possible cases as I'm not entirely familiar with the codebase yet. Any feedback would be greatly appreciated! #1013